Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add R devcontainer for statistical computing #60

Merged
merged 4 commits into from
Jun 10, 2019

Conversation

kmehant
Copy link
Contributor

@kmehant kmehant commented Jun 1, 2019

Context

We can have R devcontainer added to the present vs code development container ecosystem.

@kmehant kmehant marked this pull request as ready for review June 1, 2019 07:26
@kmehant
Copy link
Contributor Author

kmehant commented Jun 1, 2019

Hello @Chuxel
We are missing a debugging extension for R so how should we be proceeding with launch.json and the devcontainer itself.

@Chuxel
Copy link
Member

Chuxel commented Jun 5, 2019

@kmehant Thanks for the PR! A few comments:

  1. One of these extensions appears to require .NET Core which needs to be installed in the Dockerfile. Unfortunately, the R image uses the unreleased Debian buster which makes that tricky to do.
  2. Is there a reason to install both extensions?

@Chuxel Chuxel self-requested a review June 5, 2019 02:03
@kmehant
Copy link
Contributor Author

kmehant commented Jun 5, 2019

@kmehant Thanks for the PR! A few comments:

  1. One of these extensions appears to require .NET Core which needs to be installed in the Dockerfile. Unfortunately, the R image uses the unreleased Debian buster which makes that tricky to do.
  2. Is there a reason to install both extensions?

@Chuxel Thanks for the valuable review! Let me remove R Tools extension for now as the other extension satisfies the basic needs (syntax, snippet and run) for programming in R and will update the readme more aptly to the development 😄

@Chuxel
Copy link
Member

Chuxel commented Jun 6, 2019

Thanks for the valuable review! Let me remove R Tools extension for now as the other extension satisfies the basic needs (syntax, snippet and run) for programming in R and will update the readme more aptly to the development 😄

I expect people will want to use the other extension give it provides more features, so ideally we'd figure out how to get .NET Core into the container so it can be used.

@kmehant
Copy link
Contributor Author

kmehant commented Jun 9, 2019

@Chuxel I have used R base image which is built on top of Ubuntu:bionic and installed .NET core runtime 2.1 and libzip as dependencies for R Tools extension.

@kmehant
Copy link
Contributor Author

kmehant commented Jun 9, 2019

@Chuxel Can we get this merged 😃?

@Chuxel Chuxel merged commit 7d981b9 into microsoft:master Jun 10, 2019
@Chuxel
Copy link
Member

Chuxel commented Jun 10, 2019

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants